Re: Oracle patch [files]
| From: | thies at digicol dot de | Date: | Fri, 14 Jul 2000 15:41:16 +0000 |
| Subject: | Re: Oracle patch [files] | ||
| References: | 1 2 3 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-24539@lists.php.net to get a copy of this message | ||
On Mon, Jul 10, 2000 at 03:50:34PM +0400, Kirill Maximov wrote:
> thies@digicol.de wrote:
> >
> > On Mon, Jul 10, 2000 at 03:25:03PM +0400, Kirill Maximov wrote:
> > >
> > > Oh, forget this.
> >
> > i'll apply this later. it needs some changes though: global
> > variables are your enimy in a multi-threaded environment. so
> > the PHP 4 version of the patch needs to be made thread-safe.
>
> Oh, I see. I didn't hope that my code doesn't need a change :)
>
> > (see the usage of ORA() macro to see how that is done). i
> > also like to make the code consistent with the indention we
> > use in the rest of the module (and most of the rest of PHP).
>
> Sorry, I didn't notice wrong indentation of my code.
>
> Best regards,
> KIR
applying right now, please note that i changed the patch a
tiny bit: to get the global error-status call Ora_Error
*without* parameters.
tc
>
> --
> ---- ----- ----- ----- ----- ----- ----- -----
> Kirill Maximov maxkir@email.com
> ICQ: 14796643
--
Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!"
Digital Collections Phone +49 40 235350 Fax +49 40 23535180
Hammerbrookstr. 93 20097 Hamburg / Germany