Re: Oracle patch [files]

thies@digicol.de wrote: > > On Mon, Jul 17, 2000 at 10:43:13AM +0400, Kirill Maximov wrote: > > > > > > thies@digicol.de wrote: > > > > > > On Mon, Jul 10, 2000 at 03:50:34PM +0400, Kirill Maximov wrote: > > > > thies@digicol.de wrote: > > > > > > > > > > On Mon, Jul 10, 2000 at 03:25:03PM +0400, Kirill Maximov wrote: > > > > > > > > > > > > Oh, forget this. > > > > > > > > > > i'll apply this later. it needs some changes though: global > > > > > variables are your enimy in a multi-threaded environment. so > > > > > the PHP 4 version of the patch needs to be made thread-safe. > > > > > > > > Oh, I see. I didn't hope that my code doesn't need a change :) > > > > > > > > > (see the usage of ORA() macro to see how that is done). i > > > > > also like to make the code consistent with the indention we > > > > > use in the rest of the module (and most of the rest of PHP). > > > > > > > > Sorry, I didn't notice wrong indentation of my code. > > > > > > > > Best regards, > > > > KIR > > > > > > applying right now, please note that i changed the patch a > > > tiny bit: to get the global error-status call Ora_Error > > > *without* parameters. > > > > Will call ora_error(0) work ? > > no, only > > ora_error(); > > will work - i don't think that passing an invalid id > (tresource) should yield you a "valid" result. so calling it > without paramters gets you the global (non-connected) > error-code. OK, no problem here. I'll correct PHP-LIB code appropriately. Thanks a lot. KIR -- ---- ----- ----- ----- ----- ----- ----- ----- Kirill Maximov maxkir@email.com ICQ: 14796643