Re: Bug in oracle.c in php4

Hi, it seems that you cannot check if ZEND_FETCH_RESOURCE2 succeeds or not. I reversed the patch. Derick Kirill Maximov wrote: > > Hello, > > It seems that latest patch (1.52->1.53) to ext/oracle/oracle.c is buggy. > I'm unable to compile php4 with 1.53 version of oracle.c on > my Solaris x86 box. With 1.52 it's ok. > > Error is as follows: > > /bin/sh /h/home/kir/SRC/php4/libtool --silent --mode=compile gcc -I. -I/h/home/ > kir/SRC/php4/ext/oracle -I/h/home/kir/SRC/php4 -I/h/home/kir/SRC/php4/main -I/h/ > home/kir/SOFT/include -I/h/home/kir/SRC/php4/Zend -I/h/home/kir/SRC/php4 -I/usr/ > local/include -I/usr/local/include/freetype -I/h/home/kir/SRC/php4/ext/mysql/lib > mysql -I/u/oracle7/rdbms/public -I/u/oracle7/rdbms/demo -I/u/oracle7/network/pub > lic -I/h/home/kir/SRC/php4/ext/xml/expat/xmltok -I/h/home/kir/SRC/php4/ext/xml/e > xpat/xmlparse -I/h/home/kir/SRC/php4/TSRM -D_POSIX_PTHREAD_SEMANTICS -DXML_BYTE > _ORDER=12 -g -O2 -c oracle.c > oracle.c: In function `php_if_ora_close': > oracle.c:605: parse error before `;' > oracle.c:605: parse error before `==' > oracle.c: At top level: > oracle.c:606: parse error before `return' > oracle.c:607: parse error before `(' > make[3]: *** [oracle.lo] Error 1 > > > cvs log record for oracle.c is: > ------------------------------- > revision 1.53 > date: 2000/10/09 18:45:55; author: derick; state: Exp; lines: +2 -1 > - Made ora_close return values like it should (thanks to james@php.net and > mathieu@gginter.net) > ---------------------------- > > > With best regards, > Kirill Maximov. > > ------------------------------------------------------------------------ > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net > For additional commands, e-mail: php-dev-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net -- Derick Rethans JDI Media Solutions H.v.Tussenbroekstraat 1 6952 BL Dieren The Netherlands e-mail: d.rethans@jdimedia.nl http://www.jdimedia.nl/