Re: Bug in oracle.c in php4

He's not using the macro here. On Tue, 10 Oct 2000, Derick Rethans wrote: > Hello, > > Kirill Maximov wrote: > > > > } > > > ZEND_FETCH_RESOURCE(cursor, , ); > > > > On an error, it'll return NULL here. I'm afraid, it should be like this: > > > > cursor = (oraCursor *) zend_fetch_resource(arg, -1, "Oracle-Cursor", NULL, 1, > > le_cursor); > > if (!cursor) > > RETURN_FALSE; > > > > could be my mistake, but I thougt ZEND_FETCH_RESOURCE imediately returns from the function > with NULL, so > > if (!cursor) > > will never be reached. > > > > > > > > > > > if (zend_list_delete((*arg)->value.lval) == FAILURE) > > > RETURN_FALSE > > > > > > RETURN_TRUE; > > > } > > > /* }}} */ > > -- > Derick Rethans > JDI Media Solutions > > H.v.Tussenbroekstraat 1 > 6952 BL Dieren > The Netherlands > > e-mail: d.rethans@jdimedia.nl > http://www.jdimedia.nl/ > > > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net > For additional commands, e-mail: php-dev-help@lists.php.net > To contact the list administrators, e-mail: php-list-admin@lists.php.net > >