Re: Fwd: [PHP] upload_max_size vs. post_max_size
| From: | Andi Gutmans | Date: | Mon, 13 Nov 2000 14:34:56 +0000 |
| Subject: | Re: Fwd: [PHP] upload_max_size vs. post_max_size | ||
| References: | 1 2 3 4 5 6 7 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-37912@lists.php.net to get a copy of this message | ||
At 08:31 AM 11/13/00 -0600, Andrei Zmievski wrote:
On Mon, 13 Nov 2000, Andi Gutmans wrote: I prefer not having both of these options but just one. Language wise it makes more sense to keep the post_max_size directive because it includes everything and not only file uploads but as people have always used upload_max_size it might be better to keep the old name. Also the main question is if it is better to only have one option. They actually aren't completely the same. The post_max_size checks the content_length and makes sure it's not longer than the directive, the upload_max_size is checked in rfc1867.c to see if the uploaded file doesn't exceed a certain size. At least to me it's not obvious how to deal with it. Discussion? Can we always rely on content-length header being truthful?Not if someone willingly creates a bad request but in this case you might not reach the upload_max_size() directive either. Andi --- Andi Gutmans <andi@zend.com> http://www.zend.com/