Re: output buffering
| From: | Zeev Suraski | Date: | Thu, 23 Nov 2000 18:18:03 +0000 |
| Subject: | Re: output buffering | ||
| References: | 1 2 3 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-39025@lists.php.net to get a copy of this message | ||
That has nothing to do with that - you seemed to recode major parts of the output buffering mechanism, whereas adding chunk support shouldn't be more than changing 20-30 lines in the code.
I don't agree that only chunked buffering makes sense - in the vast majority of cases, full output buffering would be fine. With very large output, chunked buffering is probably better.
Zeev
At 20:10 23-11-00, Jade Nicoletti wrote:
I'm a perfectionist ;) That's why. Only chunked buffering makes sense if one uses it with a handler (performance wise). -Jade. On Tue, Nov 21, 2000 at 04:18:05PM +0200, Zeev Suraski wrote: You've made some pretty revolutionary changes to the output buffering code... The question is why :) Buffering blocks, and invoking handler functions every time the buffer gets full (instead of resizing it) makes sense, and is something I've been meaning to do at some point or another. But it really doesn't require the huge rewrite you've made... So, I go to back to the original question - why? :) Zeev At 16:03 21-11-00, Jade Nicoletti wrote:-- Zeev Suraski <zeev@zend.com> CTO, Zend Technologies Ltd. http://www.zend.com/I'm not happy with the output buffering as it is now. There should be a possibilty to just buffer blockwise. I've tryed to implement it, but my knowledge about zend internals/macros (at it's current stage) isn't sufficient. I appended my work, so that you can look at it and if you think it's agoodthing, you can fix it and integrate it. I wannted to do my work on the output compression handler on better base, that's way I've first tried to do this stuff. Current handler API:========ob_start(string handler); string handler(string entire_output);Proposed new handler API:ob_start(string handler [, int flags]); # flags: 1 -> blockwise.. string handler(string chunk [, int flags]); # flgs: 1 -> notlast chunk I hope you got it :) -Jade. PS: feel free to ask your questions :) -- =======================================================================-- Zeev Suraski <zeev@zend.com> CTO, Zend Technologies Ltd. http://www.zend.com/ -- ===============================================================================Jade Nicoletti Nicoletti Net Services Tel. 01 240 4774 Geschäftsleitung Postfach 2519 Fax 01 240 4775 System-Administration 8021 Zürich============================================[ Weitere Infos: http://nns.ch/ ]==Jade Nicoletti Nicoletti Net Services Tel. 01 240 4774 Geschäftsleitung Postfach 2519 Fax 01 240 4775 System-Administration 8021 Zürich ============================================[ Weitere Infos: http://nns.ch/ ]==