Re: itoa() unresolved

On Fri, 5 Feb 1999, Andreas Karajannis wrote: > Shane Caraveo wrote: > > > > No, and I knew it wasn't when I put it there. As I understand the code, > > curopt is the number of connections to made to the odbc manager. If > > someone can make 10000 connections to an odbc manager, they're god (at > > least on nt). Anyway, yes it needs to be fixed, but I needed an > > immediate fix before going out the door to the airport. > > > > Shane > > > > cur_opt are connection options needed for, I think empress. > Since we can find the maximum possible value for this constant (it's > defined as 2UL), it should be safe to simply use a constant value of 3 > (1 digit and 2 extra) for the maximum length of cur_opt. > Though this isn't elegant and we waste two bytes ;-) Steve, could you verify that we didn't break anything with respect to Empress here? I am talking about Shane's fix: http://cvs.php.net/cvsweb.cgi/functions/unified_odbc.c.diff?r1=1.100&r2=1.101&f=h followed by Andreas' change: http://cvs.php.net/cvsweb.cgi/functions/unified_odbc.c.diff?r1=1.101&r2=1.102&f=h -Rasmus -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net