RE: [PHP-DEV] Changing implementation of get_meta_tags for 4.0.5

Is the only thing it fixes the multi-line problem? (In such a case I think doing the fix is fine). Also, in your example when you wrote "= NULL" I hope you meant not to define these at all and not making them NULL. It is better (traversal and such). Last but not least, you could send an Email to php-general@ and ask who uses it and how. It will give you an idea if there are lots of people or none. Again, if the only problem you fixed is the multi-line problem then I think people won't get bitten by this. Andi At 01:01 AM 2/14/2001 -0500, Sean R. Bright wrote:

Well I certainly don't want to compare it to changes from PHP3 to PHP4, but this really isn't that huge of a change. The only difference is that this time this function will actually work correctly. Its never a Good Thing (tm) to break backwards compatibility but that shouldn't be the only thing reason to not change the implementation. If you guys want it to be another function could someone suggest a name for it? get_meta_tags_ex?? Sean -----Original Message----- From: Andi Gutmans [mailto:andi@zend.com] Sent: Wednesday, February 14, 2001 12:41 AM To: André Langhorst; elixer@erols.com; PHP Development Subject: Re: [PHP-DEV] Changing implementation of get_meta_tags for 4.0.5 Well maybe we can have a function with another name? or pass an optional second argument? I'm not that sure it's a good thing to break backwards compatibility on this one although I admit not knowing how many people actually use it. My guess is that if it's been in a couple of versions of PHP 4 there are at least a couple of dozen if not more using it. Andi At 11:34 PM 2/13/2001 +0100, André Langhorst wrote:

This will break backwards compatibility, and I am not

really in favor of

adding a new param to get_meta_tags in order to include this new functionality, that will just obfuscate the code more than

it needs to be.

I think we should just change one implementation, to

another, better one. I

can't imagine that that many people are using this tag

often enough to

require a huge change in their code.

following your description, that function is really broeken (lack of functionality) and thus needs a non-backwards-compatible

fix, your fix

sounds nice indeed this function is not widespreadly used I guess 2c --

· André Langhorst        t: +49 331 5811560 ·
· andre@php.net          m: +49 173 9558736 ·

* PHP Quality Assurance http://qa.php.net * -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail:

php-list-admin@lists.php.net -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, e-mail: php-dev-unsubscribe@lists.php.net For additional commands, e-mail: php-dev-help@lists.php.net To contact the list administrators, e-mail: php-list-admin@lists.php.net