Re: CVS update: php3
| From: | Rasmus Lerdorf | Date: | Thu, 01 Jan 1970 00:00:00 +0000 |
| Subject: | Re: CVS update: php3 | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-5561@lists.php.net to get a copy of this message | ||
> -/* $Id: control_structures_inline.h,v 1.195 1999/04/16 06:10:23 rasmus Exp $ */
> +/* $Id: control_structures_inline.h,v 1.196 1999/05/12 08:08:19 thies Exp $ */
>
> #ifdef THREAD_SAFE
> #include "tls.h"
> @@ -1202,7 +1202,12 @@
> } else if (arr_ptr->type!=IS_ARRAY) {
> php3_error(E_WARNING,"Index referencing a non-array");
> result->value.varptr.pvalue=NULL;
> - pval_destructor(expr _INLINE_TLS);
> +
> + /* XXX thies@digicol.de i don't know if this is right -
> + but it fixes a crash 990512 */
> + if (expr) {
> + pval_destructor(expr _INLINE_TLS);
> + }
> return;
> }
> if (expr) {
Hrm.. What was the user-level code that triggered this crash? Your fix
does seem harmless though. But you may only be fixing the symptom and not
the actual cause.
-Rasmus
--
PHP Development Mailing List http://www.php.net/
To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net
For help: php-dev-help@lists.php.net