Re: CVS update: php3

hi rasmus, i from time to time find a coredump of my apache.... to be quite honest, i have NO idea whatsoever what page/script causes this - but looking at the code tells me that the expr could be zero : if (expr) 3 lines below..... as we all know there are "random" crashed from time-to-time (at least for me) - and whenever i find a core, i will try to track it down. sorry again, no script.... maybe the guy who wrote this could have a look (zeev, andi?) tc On Wed, 12 May 1999, Rasmus Lerdorf wrote: > > -/* $Id: control_structures_inline.h,v 1.195 1999/04/16 06:10:23 rasmus Exp $ */ > > +/* $Id: control_structures_inline.h,v 1.196 1999/05/12 08:08:19 thies Exp $ */ > > > > #ifdef THREAD_SAFE > > #include "tls.h" > > @@ -1202,7 +1202,12 @@ > > } else if (arr_ptr->type!=IS_ARRAY) { > > php3_error(E_WARNING,"Index referencing a non-array"); > > result->value.varptr.pvalue=NULL; > > - pval_destructor(expr _INLINE_TLS); > > + > > + /* XXX thies@digicol.de i don't know if this is right - > > + but it fixes a crash 990512 */ > > + if (expr) { > > + pval_destructor(expr _INLINE_TLS); > > + } > > return; > > } > > if (expr) { > > Hrm.. What was the user-level code that triggered this crash? Your fix > does seem harmless though. But you may only be fixing the symptom and not > the actual cause. > > -Rasmus > > > -- > PHP Development Mailing List http://www.php.net/ > To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net > For help: php-dev-help@lists.php.net > > > Thies C. Arntzen "One Big-Mac, Small Fries and a Coke!" Digital Collections Phone +49 40 235350 Fax +49 40 23535180 Hammerbrookstr. 93 20097 Hamburg / Germany -- PHP Development Mailing List http://www.php.net/ To unsubscribe send an empty message to php-dev-unsubscribe@lists.php.net For help: php-dev-help@lists.php.net