Re: Re: [ZEND-ENGINE] cvs: Zend / zend.c zend_execute_API.c zend_hash.c zend_hash.h zend_list.c zend_list.h

At 08:38 02/08/2001, Thies C. Arntzen wrote:

On Thu, Aug 02, 2001 at 07:09:35AM -0700, rasmus@lerdorf.on.ca wrote:

On Thu, 02 Aug 2001, Zeev Suraski wrote:

zeev              Thu Aug  2 09:16:20 2001 EDT

Modified files:

    /Zend zend.c zend_execute_API.c zend_hash.c zend_hash.h zend_list.c
          zend_list.h

Log: Some cleanup

I really wish all these TSRM changes were left for 4.1. There are just way too many functions affected and I guarantee you that all the standalone extensions will be broken because people will not expect such breakage from a point release.

It also breaks binary compatibility forcing everyone to release new extensions. The change from ZEND_API void wrong_param_count() to ZEND_API void zend_wrong_param_count(TSRMLS_D) Makes extensions built for 4.0.6 break against current CVS right now: PHP Warning: Unable to load dynamic library '/usr/local/lib/php/php_ming.so' - /usr/local/lib/php/php_ming.so: undefined symbol: wrong_param_count in Unknown on line 0

    binary compatiblity was already broken some time ago in the
    4.0.7-branch.

    right now we have also lost source-code compatiblity due to
    the TSRM stuff, i think we should try to get at least
    source-code compatiblity back before we release 4.0.7.

    zeev, any idea what would be needed to do that - or is that
    already on your "list"?

No, it's not on my list. Source code compatibility for the thread-safe mode isn't very important in my opinion, but I'll probably take a look at it myself next week anyway. Zeev