Re: Re: cvs: php4 /ext/sablot php_sablot.h
| From: | Zeev Suraski | Date: | Fri, 10 Aug 2001 14:57:39 +0000 |
| Subject: | Re: Re: cvs: php4 /ext/sablot php_sablot.h | ||
| References: | 1 2 3 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-62835@lists.php.net to get a copy of this message | ||
At 17:31 10-08-01, Andrei Zmievski wrote:
On Fri, 10 Aug 2001, derick@php.net wrote: This is not about renaming, it's about removing duplicate macro's. Of course it's about renaming. We used to have just PHP_* macros and then Zeev added the ZEND_* versions and now PHP_* ones are just aliased to ZEND_* ones for "backwards compatibility".From a technical perspective, if I change the prototype of the activation function, which is obviously in the engine, how does it make sense that I'll have to change macros outside the engine, instead of changing them inside the engine? Or worse, change them in two places? If there's more Zend-o-phobia, we can have #define PHP_* ZEND_* for some Zend macros. I see a benefit in having modules compile independently of PHP so that they can plug into the stand alone engine in the future, but frankly, I don't care too much - we can move them to php.h instead of php3_compat.h. It doesn't change the fact that the replicated macros had to go. Zeev