[patch] avoiding TSRMLS_FETCH (custom sorting functions)
| From: | Sterling Hughes | Date: | Mon, 17 Sep 2001 14:18:29 +0000 |
| Subject: | [patch] avoiding TSRMLS_FETCH (custom sorting functions) | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-66117@lists.php.net to get a copy of this message | ||
Hey,
Attached is a patch which replaces the use of libc's quicksort
and uses our own custom quicksort for quicksort sorting, giving
the immediate benefit of allowing us to pass TSRMLS_CC to the callbacks,
and avoid a TSRMLS_FETCH(). The patch also applies the changes to
our mergesort implementation.
I've put the function in a seperate file in Zend, zend_qsort.c
(instead of as a file in php4/main) for two reasons:
1) qsort() is used by Zend
2) its a fairly common function, and re-implemented in order to play
nice with Zend's TS mechanism, this should be made available to all
programs using Zend.
Comments are appreciated and welcome... I'll commit after an
appropriate mourning period if no one speaks up.
-Sterling