Re: [patch] avoiding TSRMLS_FETCH (custom sorting functions)

From: Date: Tue, 18 Sep 2001 09:59:21 +0000
Subject: Re: [patch] avoiding TSRMLS_FETCH (custom sorting functions)
References: 1  Groups: php.dev 
Request: Send a blank email to php-dev+get-66165@lists.php.net to get a copy of this message
On Mon, Sep 17, 2001 at 10:18:29AM -0400, Sterling Hughes wrote: > Hey, > > Attached is a patch which replaces the use of libc's quicksort > and uses our own custom quicksort for quicksort sorting, giving > the immediate benefit of allowing us to pass TSRMLS_CC to the callbacks, > and avoid a TSRMLS_FETCH(). The patch also applies the changes to > our mergesort implementation. > > I've put the function in a seperate file in Zend, zend_qsort.c > (instead of as a file in php4/main) for two reasons: > > 1) qsort() is used by Zend > 2) its a fairly common function, and re-implemented in order to play > nice with Zend's TS mechanism, this should be made available to all > programs using Zend. > > Comments are appreciated and welcome... I'll commit after an > appropriate mourning period if no one speaks up. cool - i'm all for it! tc

« previous php.dev (#66165) next »