Re: curl compiler failed

From: Date: Tue, 25 Sep 2001 07:41:08 +0000
Subject: Re: curl compiler failed
References: 1  Groups: php.dev 
Request: Send a blank email to php-dev+get-66512@lists.php.net to get a copy of this message
SH>> I'd expect it to work with all php's above 4.0.8, the only problem SH>> is that if you link PHP 4.0.8 with an older version of CURL this SH>> will cause PHP compilation errors that maybe unforseen, therefore, SH>> to right it truly portable, you need two version checks for each new SH>> piece of code. SH>> SH>> if (phpversion == 4.0.8 && curl_version == 7.9) { SH>> curl_setopt($ch, CURLOPT_SSL_VERIFYRESULT, 1); SH>> } No, I need just: if ($curl_version >= 7.9) { curl_setopt($ch, CURLOPT_SSL_VERIFYRESULT, 1); } And this is way better for one simple reason - it's easy to know which version of cURL CURLOPT_SSL_VERIFYRESULT appeared in. It's pretty hard to know which version of PHP is required for that, unless you are familiar with CVSweb and stuff (or depend on ChangeLog and people really documenting changes in their commit messages - which is not the case, unfortunately). This is also way better for logical reasons - you don't really need PHP 4.0.8 here, you need recent cURL, right? You couldn't care less for PHP version one it supports what you want. Also, imagine this is a stand-alone extension - oops. You need to check version anyway, since it is not linked to any specific PHP release. Won't it be logical to just check what you want to know instead of trying to shave with an axe? -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115

« previous php.dev (#66512) next »