RE: [PHP-DEV] fix for bug #1520 (new diff)
| From: | Brian Schaffner | Date: | Wed, 09 Jun 1999 22:57:08 +0000 |
| Subject: | RE: [PHP-DEV] fix for bug #1520 (new diff) | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-6784@lists.php.net to get a copy of this message | ||
ok, i hope everyone's not as impcompetent as i am. please hold off on that
last diff,
because some of us (ME) didn't realize that file upload also has _type &
_size... (even though I was just staring at the code....)
so, let me add that stuff so this will at least be complete and consistent.
-brian-
> -----Original Message-----
> From: Brian Schaffner [mailto:BSchaffner@accentonline.com]
> Sent: Wednesday, June 09, 1999 6:05 PM
> To: 'php-dev@lists.php.net'
> Subject: RE: [PHP-DEV] fix for bug #1520 (new diff)
>
>
>
> ok, nobody's perfect. this diff replaces the previous diff.
>
> fixed a problem in that thefile[] gets mangled to
> thefile[]_name. this puts
> all the data into an array called thefile[] rather than the preferred
> thefile[] for the temps and thefile_name[] for the name.
> someone should
> make sure that the extra 4 bytes for the emalloc is cool - i
> hacked that
> part...
> and it worked, so....
>
> i really didn't get this:
>
> MAX(MAX(sizeof("_name"),sizeof("_size")),sizeof("_type"))
>
> anyhow - new fix, please put in cvs. blah blah blah...
>
> -brian-
>
> > -----Original Message-----
> > From: Brian Schaffner [mailto:BSchaffner@accentonline.com]
> > Sent: Wednesday, June 09, 1999 5:19 PM
> > To: 'php-dev@lists.php.net'
> > Subject: [PHP-DEV] fix for bug #1520
> >
> >
> > I've attached the diff for mime.c that fixes the bug
> > described in bug #1520.
> > Essentially I replaced a few instanes of SET_VAR_STRING with
> > _php3_parse_gpc_data(). This accomplished putting the uploaded file
> > variables into the HTTP_POST_VARS and allowed uploaded file
> > variables to be
> > arrays.
> >
> > -brian-
> >
> >
>
>