Re: RE: [PHP-CVS] cvs: php4 /ext/ftp ftp.c ftp.h

> > I just left it with the new sizeof, but there may be side-effects? > It's okay as long as you don't have IPv6, 95/98 doesn't. Well, it should run on all other win versions too (except 16-bit crap) > and commit something tomorrow I hope. Nice if you can help test that > too then. I guess you used passive get now, could you check if it > works with normal (active) get? Nope, that won't get through our firewall, and I don't have an ftp-server inside (I scp everything) > As you mentioned, the php_connect_nonb() has a comment about > probably not working on Win32. What happens is that it just does a > normal connect() and not the timeout code Yeah, I noticed that after my post :) > works or not. If you feel like it, you might try to remove the > "&& !defined(PHP_WIN32)" part and check whether it compiles and if > the timeout works. Would be neat if we could have timeouts on Win32 > as well. If we fix it, it will make timeouts work other places too. That is for every win32, right? Not just 95/98? I'll test that soon... (don't be afraid to remind me, I'm swamped in work normally :) Cheerio, Marc.