your patch to session.c broke it (testcase included)
| From: | Thies C. Arntzen | Date: | Mon, 04 Mar 2002 11:18:05 +0000 |
| Subject: | your patch to session.c broke it (testcase included) | ||
| Groups: | php.dev | ||
| Request: | Send a blank email to php-dev+get-80689@lists.php.net to get a copy of this message | ||
zeev,
your patch
http://cvs.php.net/diff.php/php4/ext/session/session.c?r1=1.277&r2=1.278&ty=u
broke the session module:
testcase (run multiple times using php-cgi from the command-line)
<?php
session_id("thies");
session_start();
if (! session_is_registered("hallo")) {
$hallo = "hi ";
session_register('hallo');
} else {
$hallo = &$_SESSION[ 'hallo' ];
}
echo "$hallo\n";
$hallo .= '!';
?>
after your patch the changed value of $hallo is no longer remembered.
hmm, as i don't know wich "crash bug" your patch fixes i
don't want to simply revert it - could you give me some
insights?
re,
tc