Re: your patch to session.c broke it (testcase included)

At 13:18 04/03/2002, Thies C. Arntzen wrote:

    zeev,
    your patch

http://cvs.php.net/diff.php/php4/ext/session/session.c?r1=1.277&r2=1.278&ty=u

    broke the session module:

    testcase (run multiple times using php-cgi from the command-line)

<?php session_id("thies"); session_start(); if (! session_is_registered("hallo")) {

    $hallo = "hi ";
    session_register('hallo');

} else {

    $hallo = &$_SESSION[ 'hallo' ];

} echo "$hallo\n"; $hallo .= '!'; ?>

    after your patch the changed value of $hallo is no longer remembered.

    hmm, as i don't know wich "crash bug" your patch fixes i
    don't want to simply revert it - could you give me some
    insights?

Well, I didn't find any crashes, but it is a potential crash, because the zval is put into the hash with a wrong refcount. Did you try rolling back this particular patch and it works again? You said I should run this using php-cgi from the command line, how exactly is this supposed to work with sessions (which rely on HTTP cookies, or am I missing something? :) Zeev