Re: Re: cvs: php4 /ext/standard basic_functions.c basic_functions.h

okay, so then what is the point of adding a new function to read an uploaded file? it sounds like the original justification was completely off-base. the original patch said: I created function read_uploaded_file(), i think it is useful at to work with uploaded file in safe_mode and open_basedir, because if i need only file content and safe_mode=on or open_basedir is set, i can not read file, i must move it, read and delete then. (http://news.php.net/article.php?group=php.dev&article=81624) i hear from you and stefan that this is wrong. so what's the point of this new function? and if this isn't entirely wrong, i think we would be better off fixing safe_mode and open_basedir to allow opening uploaded files rather than adding a special function for this. jim On Sat, Mar 23, 2002 at 09:45:28AM -0800, Rasmus Lerdorf wrote: > That's already the case though. > > On 23 Mar 2002, Jim Winstead wrote: > > > Andi Gutmans <andi@zend.com> wrote: > > > I don't think having a function which outputs an uploaded file is useful. > > > So please only implement one which returns the file. > > > > wouldn't it be most useful to have a function that just *opens* the > > uploaded file, so people can use fpassthru() or fread() or fgets() or > > fgetss()? > > > > (or even just make it so that when safe mode is on, it is smart enough > > to allow opening files that were uploaded without doing the uid check?) > > > > jim