Re: Re: cvs: php4 /ext/standard basic_functions.c basic_functions.h

Brain freeze. We already have a file_get_contents() function courtesy of Wez's streams stuff. So basically there is no merit at all to this patch. Derick, please revert. -Rasmus On Sat, 23 Mar 2002, Andi Gutmans wrote: > At 11:11 23/03/2002 -0800, Rasmus Lerdorf wrote: > > > okay, so then what is the point of adding a new function to read an > > > uploaded file? it sounds like the original justification was completely > > > off-base. > > > >Yup, as far as I can see it is a completely useless function other than > >the fact that it reads an entire file into a string. This is actually > >something we should add, but it should be a generic load_file() or > >str_file() or some other such function. > > > No matter what is decided let's use the file_*() standard for new functions. > > Andi >