Re: cvs: php4 /sapi/cli README php_cli.c

From the ongoing discussion i assume that you wanted setting infinite time limit only when no php.ini was found - but that does only make sense when a special section in php.ini is available because otherwise you will either have no php.ini or the setting of the cgi version or multiple ini files that have mostly the same content. marcus At 18:21 24.03.2002, you wrote:

    That is exactly what Derick and I meant and is not a good
    idea. Cannot we set the default settings _before_ php.ini
    parsing is done ?!

    set_time_limit() still works but settings it in PHP.INI does
    not?

    IMHO this is unacceptable inconsistency.

    - Markus

On Sun, Mar 24, 2002 at 05:14:34PM -0000, Edin Kadribasic wrote :

edink         Sun Mar 24 12:14:34 2002 EDT

Modified files:

    /php4/sapi/cli    README php_cli.c

Log: Override max_execution_time, setting it to unlimited. Index: php4/sapi/cli/README diff -u php4/sapi/cli/README:1.2 php4/sapi/cli/README:1.3 --- php4/sapi/cli/README:1.2 Sat Mar 23 18:47:10 2002

+++ php4/sapi/cli/README      Sun Mar 24 12:14:34 2002

@@ -15,3 +15,4 @@ * implicit_flush always on * -r option which allows execution of PHP code directly from the command line (e.g. php -r 'echo md5("test");' ) +* max_execution_time is set to unlimited, overriding php.ini setting. Index: php4/sapi/cli/php_cli.c diff -u php4/sapi/cli/php_cli.c:1.13 php4/sapi/cli/php_cli.c:1.14

--- php4/sapi/cli/php_cli.c:1.13      Sat Mar 23 12:10:31 2002

+++ php4/sapi/cli/php_cli.c Sun Mar 24 12:14:34 2002 @@ -397,6 +397,7 @@

              SG(options) |= SAPI_OPTION_NO_CHDIR;
         zend_alter_ini_entry("html_errors", 12, "0", 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE);
              zend_alter_ini_entry("implicit_flush", 15, "1", 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE);
+             zend_alter_ini_entry("max_execution_time", 19, "0", 1, PHP_INI_SYSTEM, PHP_INI_STAGE_ACTIVATE);

              while ((c = ap_php_getopt(argc, argv, OPTSTRING)) != -1) {
                      switch (c) {

-- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php -- Please always Cc to me when replying to me on the lists. GnuPG Key: http://guru.josefine.at/~mfischer/C2272BD0.asc -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php