Re: new port
| From: | Stanislav Malyshev | Date: | Sun, 07 Apr 2002 09:01:12 +0000 |
| Subject: | Re: new port | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-82232@lists.php.net to get a copy of this message | ||
fw>> it to compile (which is not a simple task!), and notice an enormous amount
fw>> of bad casting in the code. For example:
fw>>
fw>> int joe = (ulong) *p;
Things like this should be fixed, I think - that's a bug, plain and
simple, since ulong and int can have different size, and you get data loss
here (unless you are 100% sure *p is fitting int, in which case it should
be commented in the code).
Can you point out some of the examples where this happens?
--
Stanislav Malyshev, Zend Products Engineer
stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115