Re: new port

This isn't really an error because the argument count can't overflow in this situation. In any case, I'll see if we can't clean up these warnings a bit by making the l-values ulong. Andi At 13:48 07/04/2002 -0400, fabwash wrote:

Hello, I achieved the first step of victory last night I got a php object created at 5am :) It's only the first step and it will take a long time to get something I can really run, I have a bunch of unresolved references and the first thing it did when I ran it was to signal. I will go through every source file with a warnings and implicit declarations so it will take some time. The most annoying one for now is one that is being included all the time: zend_language_parser.c: /bin/sh ../libtool --silent --mode=compile c89 -D_TANDEM_SOURCE -D_XOPEN_SOURCE_EXTENDED -WIEEE_float -DHAVE_CONFIG_H -

I. -I. -I../main    -I../TSRM  -prefer-non-pic -static -c

zend_language_parser.c

            int delete_count = (ulong)  *p;

"/usr/people/fab/php-4.1.2/Zend/zend_execute.h", line 110: warning(1506): implicit conversion from "unsigned long" to "int": rounding, sign extension, or loss of accuracy may result Same thing on line 122: int arg_count = (ulong) *p; I have some work to do on the ./configure first. Unfortunately the system i'm working on will not fail when a test is done to check the existence of a procedure by compiling it like cc does. That makes ./configure think that I have procedures that I really don't, hence the unresolved references when the link is done. Once I fix this and make ./configure understand my system better, i'll see how I can log the implicit castings and send the log to a place where you can take a look and correct if necessary. Later, Fab. ----- Original Message ----- From: "Stanislav Malyshev" <stas@zend.com> To: "fab wash" <fabwash@hotmail.com> Cc: <php-dev@lists.php.net> Sent: Sunday, April 07, 2002 5:01 AM Subject: Re: [PHP-DEV] new port fw>> it to compile (which is not a simple task!), and notice an enormous amount fw>> of bad casting in the code. For example: fw>> fw>> int joe = (ulong) *p; Things like this should be fixed, I think - that's a bug, plain and simple, since ulong and int can have different size, and you get data loss here (unless you are 100% sure *p is fitting int, in which case it should be commented in the code). Can you point out some of the examples where this happens? -- Stanislav Malyshev, Zend Products Engineer stas@zend.com http://www.zend.com/ +972-3-6139665 ext.115 -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php