Re: [PATCH] rev. 2 of my apache2filters SEGV fixes
| From: | Edin Kadribasic | Date: | Wed, 10 Apr 2002 23:10:31 +0000 |
| Subject: | Re: [PATCH] rev. 2 of my apache2filters SEGV fixes | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-82528@lists.php.net to get a copy of this message | ||
> I posted this patch earlier, but this has some improvements. First
> of all, it's tabified, so we have consistent style. It also has some
> performance improvements suggested by Cliff Woolley, including one that
> will significantly improve output buffering/copying.
>
> The main guts of the patch include a overhaul/rewrite of the
> php_output_filter. It no longer requires setaside brigades, and can
> handle exactly one FILE bucket (Which it promptly passes off to PHP for
> processing). If it finds no FILE bucket, it silently passes the brigade
> bits down to the next filter. After processing a FILE, it steps out of
> the way and passes all other brigades down the chain.
>
> The SEGVs reported earlier on this list and others are fixed with
> this patch, as well as some other potential problems.
Great work. Could you please send the patch as an email attachment? You
should probably apply for the CVS account if you didn't have one already.
Edin