Re: [PATCH] rev. 2 of my apache2filters SEGV fixes

On Thu, 11 Apr 2002, Brian Havard wrote: > > - while (str_length > 0) { ... > > - str += now; > > - str_length -= now; > > - } ... > > > > - return str_length; > > + return 0; /* we wrote everything, we promise! */ > > Why did you change this to return 0? It breaks ImageJpeg > (and likely other things) as GD checks that the return value > matches the passed length & aborts if it doesn't. Because the old version was already always returning 0. If that's incorrect, it was incorrect before was well. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA