Re: domxml patch from 31 May breaks xslt_process
| From: | Brad LaFountain | Date: | Wed, 19 Jun 2002 15:08:27 +0000 |
| Subject: | Re: domxml patch from 31 May breaks xslt_process | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-85368@lists.php.net to get a copy of this message | ||
Just looking at the code quick..
I changed the DOMXML_RET_OBJ() macro so that you can pass in an already
instantated object. So if the first parameter isn't null then it will assume
that the object has been created. Sooo....
The variable rv in domxml_xslt_process() isn't initalized to NULL so the macro
is assuming it has already been create.. which it hasn't.
change:
zval *rv, *idxsl, *idxml, *idparams = NULL;
to:
zval *rv = NULL, *idxsl, *idxml, *idparams = NULL;
I'm not at my development machine so i can't patch it myself.
brad
--- Christian Stocker <chregu@bitflux.ch> wrote:
> Hi again
>
> And this is again actually meant for Brad, but i'd like to give the
> others the possibility to get find a solution, as well :)
>
> the following script segfaults since the domxml patch from 31 May:
>
> $xsl = domxml_xslt_stylesheet_file("test.xsl") ;
> $xml = xmldocfile("test.xml");
> $xml = $xsl->process($xml);
>
> It looks like, you broke something there as well.
>
> As far as i can see, it happens in
> DOMXML_RET_OBJ(rv, (xmlNodePtr) docp, &ret);
> in domxml_xslt_process()
>
> but it's faaaaaaaar to hot here to further investigate in that...
>
> chregu
>
>
>
>
__________________________________________________
Do You Yahoo!?
Yahoo! - Official partner of 2002 FIFA World Cup
http://fifaworldcup.yahoo.com