Re: Re: domxml patch from 31 May breaks BC

Hello, On Wed, 19 Jun 2002, Brad LaFountain wrote: [...] > Now as far as BC... I don't know what to say here... ither it breaks it or we > can't have the functionality. I think that it was wrong to begin with so it > isn't breaking BC but fixing a bug that people have relied on. > > > What do others think? I'd say break it in this case... I agree with you on the 'being wrong in the beginning' and as the checking for the name of the class isn't that widespread i thinkw e can afford it to break now. Derick > --- Christian Stocker <chregu@bitflux.ch> wrote: > > Hi > > > > The patch from 31 May : > > > > * added the ability to use new keywork with domxmls objects "new > > DomDocument()" > > > > breaks BC on some of my scripts (which i only realised now:..) > > > > I have some > > if (get_class($xmldoc) == "DomDocument") > > > > in my scripts, but xmldoc now returns "domdocument"... > > > > Brad, is it possible to revert that, but still having your intentions from > > then work? > > > > I know, it would be a quick fix in my scripts to check for both > > class-names, but I don't like breaking BC and i would not be the only one > > with that problem. > > > > I didn't look for a fix by myself, 'cause I hope you know a quick > > solution :) > > > > chregu > > > > -- > > christian stocker | bitflux GmbH | schöneggstrasse 5 | ch-8004 zurich > > phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 > > http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid > > 0x5CE1DECB > > > > > > > __________________________________________________ > Do You Yahoo!? > Yahoo! - Official partner of 2002 FIFA World Cup > http://fifaworldcup.yahoo.com > > -- > PHP Development Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > --------------------------------------------------------------------------- Did I help you? http://www.derickrethans.nl/link.php?url=giftlist Frequent ranting: http://www.derickrethans.nl/ --------------------------------------------------------------------------- PHP: Scripting the Web - derick@php.net All your branches are belong to me! SRM: Script Running Machine - www.vl-srm.net ---------------------------------------------------------------------------