Re: Re: Iconv

Moriyoshi Koizumi wrote:

Hello, I noticed by the recent cvs changes that iconv.c and config.m4 are now let to avoid PHP_ATOM approach, while php_iconv.h still adopts it.

Oops.

Is it really necessary? in acinclude.m4, PHP_SETUP_ICONV use PHP_DEFINE macro to make either HAVE_ICONV or HAVE_LIBICONV available. IMHO if php_iconv_supports_errno.h doesn't appear as a result of configure, there must be a build system problem, which has all but nothing to do with ext/iconv/*.

Thanks, now I see what it's doing. Anyway, Why PHP_SETUP_ICONV is defined in aclocal.m4? Except iconv, other modules are using only local config.m4. iconv's config.m4 is better to be rewritten just like other module's config.m4, isn't it? -- Yasuo Ohgaki