Re: Re: Safe Mode & open_basedir

Yasuo Ohgaki wrote:

Wez Furlong wrote:

On 08/08/02, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:

Your open_basedir/safe_mode patches were completely bogus because the streams check open_basedir and safe_mode themself.

I'm well aware of streams is checking safe mode. Are you sure all wrappers are checking open_basedir, too? Then we can get rid of some open_basedir checks.

All the wrappers are (or were when I added streams!) using streams when they open files, so the answer to your question is yes.

I must had typo when I grepped code. I see where it's checked now :)

One more question. There are 2 reasons why I thought streams does not check open_basedir. 1) I must have had typo in grep 2) I don't see option to check open_basedir While safe_mode check flag is passed, but I don't see any flag for open_basedir. I thoguht you made safe_mode check optoinal, since some internal functions do not need safe_mode check at all. Since there is no option for open_basedir, I thought it is not checked. Why didn't you make open_basedir check optional? Just curious. -- Yasuo Ohgaki