RE: [PHP-CVS] cvs: php4(PHP_4_2_2) /ext/domxml php_domxml.c
| From: | Joseph Tate | Date: | Thu, 08 Aug 2002 15:24:09 +0000 |
| Subject: | RE: [PHP-CVS] cvs: php4(PHP_4_2_2) /ext/domxml php_domxml.c | ||
| References: | 1 | Groups: | php.cvs php.dev |
| Request: | Send a blank email to php-dev+get-86655@lists.php.net to get a copy of this message | ||
Why so it is, so the version that shipped with 4.2.1 didn't compile either.
Ouch. What I'm referring to is the following:
if(ids) {
-----> iter.elementId = (xmlChar *)
iter.element = NULL;
xmlHashScan(ids, idsHashScanner, &iter);
rv = php_domobject_new(iter.element, &retnode TSRMLS_CC);
SEPARATE_ZVAL(&rv);
*return_value = *rv;
FREE_ZVAL(rv);
} else {
RETURN_FALSE;
}
This is line 2673 of php_domxml.c. There are also places with // style
comments, etc. They've since been fixed though. Amazing that that file
could go through two release cycles and a release candidate and not be
fixed. Of course I'm to blame too, but I didn't contribute that much after
4.2.0. Got reassigned to different projects that don't involve PHP.
> -----Original Message-----
> From: Christian Stocker [mailto:chregu@bitflux.ch]
> Sent: Thursday, August 08, 2002 11:03 AM
> To: Joseph Tate
> Cc: derick@php.net; PHP Developers Mailing List; php-cvs@lists.php.net
> Subject: RE: [PHP-CVS] cvs: php4(PHP_4_2_2) /ext/domxml php_domxml.c
>
>
> Hi
>
> > Oh by the way, the domxml that shipped with 4.2.2 (according to
> the labeling
> > in CVS) didn't even compile. It was not the same version that
> shipped with
> > 4.2.1. I wonder what other things were "accidentally" inserted into the
> > release without testing (since there evidently was no branch).
>
> according to the labeling on
> http://cvs.php.net/cvs.php/php4/ext/domxml/php_domxml.c
> it was the same:
>
> 1.118.2.8
> ---------
> Branch: PHP_4_2_0
> CVS Tags: php_4_2_2, php_4_2_1, php_4_2_1RC2
> Branch Point for: PHP_4_2_2
>
> though didn't look at the real files in the tarballs...
>
> chregu
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php