RE: [PHP-CVS] cvs: php4(PHP_4_2_2) /ext/domxml php_domxml.c

On Thu, 8 Aug 2002, Joseph Tate wrote: > Why so it is, so the version that shipped with 4.2.1 didn't compile either. > Ouch. What I'm referring to is the following: > > if(ids) { > -----> iter.elementId = (xmlChar *) yeah. stupid stuff :) but this was fixed 8 weeks ago in HEAD and PHP_4_2_0 (rev. 1.118.2.12), but this was after 4.2.1 and there was unfortunately no bug-fix release since then. > This is line 2673 of php_domxml.c. There are also places with // style > comments, etc. They've since been fixed though. Amazing that that file > could go through two release cycles and a release candidate and not be > fixed. The bug report was about not compiling on AIX 4.3.3 using xlc 3.6.6.6 with libxml2-2.4.23. It did compile under windows and linux (and certainly other gcc based compilers...) and obviously AIX seems not so widespread :) But there are indeed serious problems with 4.2.1 and domxml (memleaks..) and i recommend everyone dependentend on that using the stable snapshots, since this bugs are fixed there chregu Of course I'm to blame too, but I didn't contribute that much after > 4.2.0. Got reassigned to different projects that don't involve PHP. > > > -----Original Message----- > > From: Christian Stocker [mailto:chregu@bitflux.ch] > > Sent: Thursday, August 08, 2002 11:03 AM > > To: Joseph Tate > > Cc: derick@php.net; PHP Developers Mailing List; php-cvs@lists.php.net > > Subject: RE: [PHP-CVS] cvs: php4(PHP_4_2_2) /ext/domxml php_domxml.c > > > > > > Hi > > > > > Oh by the way, the domxml that shipped with 4.2.2 (according to > > the labeling > > > in CVS) didn't even compile. It was not the same version that > > shipped with > > > 4.2.1. I wonder what other things were "accidentally" inserted into the > > > release without testing (since there evidently was no branch). > > > > according to the labeling on > > http://cvs.php.net/cvs.php/php4/ext/domxml/php_domxml.c > > it was the same: > > > > 1.118.2.8 > > --------- > > Branch: PHP_4_2_0 > > CVS Tags: php_4_2_2, php_4_2_1, php_4_2_1RC2 > > Branch Point for: PHP_4_2_2 > > > > though didn't look at the real files in the tarballs... > > > > chregu > > > > > > -- > > PHP CVS Mailing List (http://www.php.net/) > > To unsubscribe, visit: http://www.php.net/unsub.php > > > -- christian stocker | bitflux GmbH | schöneggstrasse 5 | ch-8004 zurich phone +41 1 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71 http://www.bitflux.ch | chregu@bitflux.ch | gnupg-keyid 0x5CE1DECB