RE: [PHP-DEV] Thread Reading

I agree. Lets jsut get this in the tree.. -- james > > On Thu, Sep 19, 2002 at 02:28:35AM +0100, Dan Hardiker wrote : > > This doesnt demonstrate the use of the show_source (or other aliased) > > function, but I assure you - it works similarly with an optional > > parameter, defaulting to current behaviour. > > I hope you don't forget that highlight_file() already has an > optional parameter. > > mixed highlight_file ( string filename [, bool return]) > > So this would make > > mixed highlight_file ( string filename [, bool return [, bool > lineno]]) > > Pretty ugly if you ask me. These are the things we're trying > to avoif. > > I suggest replacing the second parameter with a flag-style > parameter which accepts , well, flags. > > This way BC is not broken (just assign HIGHLIGHT_RETURN a > value of 1 and HIGHLIGHT_LINENO a value of 2) and you're > done. > > <? > highlight_file("filename", HIGHLIGHT_LINENO); > ?> > > and for BC > > <? > highlight_file("filename", true); > ?> > > will still work because true will be casted to 1. > > Besides this, go ahead and commit it (if you haven't done it > already) in the behaviour you pointed out. There are no more > reasons to held this back. Let's move over to more important > things. > > - Markus > >