Re: Re: session_register warnings

At 11:06 13/10/2002, Sascha Schumann wrote:

On Sun, 13 Oct 2002, Zeev Suraski wrote: Sascha, What I, at least, fail to understand is the answer to Rasmus' initial question(s): - Are we going to break compatibility? If not, then why are we spitting out this error by default?

    If you have followed the exchange, you will have noticed that
    the buggy 4.2 behaviour cannot be maintained forever.  The
    warning is a proper debugging tool which should help
    application developers to improve their software accordingly.

I have followed it, even though I don't recall ever seeing a clear-cut statement to that extent.

no reason to 'annoy' people into changing their working code. Even if we do plan to break compatibility, it's best if we follow the lead of allow_call_time_pass_reference, and default to having this warning off.

    There is a real chance that code which triggers the warning
    fails in silent, sometimes unpredictable ways.  It is
    therefore necessary that this warning defaults to on.

In my opinion, the bottom line is that the damage this warning will do (if it defaults to being on) far outweighs the good it may do. The very same could be said about the call-time pass by reference issue, and yet, the primary concern is downwards compatibility, and code cleanliness only comes second. I'm in favour of keeping that notice, but having it default to off. Zeev