RE: [PHP-DEV] [PHP-QA] Logs of failed tests PHP 4.3.0pre1 (fwd)
| From: | Melvyn Sopacua | Date: | Sun, 20 Oct 2002 20:49:00 +0000 |
| Subject: | RE: [PHP-DEV] [PHP-QA] Logs of failed tests PHP 4.3.0pre1 (fwd) | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-89771@lists.php.net to get a copy of this message | ||
At 18:48 20-10-2002, Mike Robinson wrote:
Michael Mauch wrote: I doubt that the C library does anything useful with non-ASCII characters while you are in a "C" or "POSIX" locale, so expat or PHP can't do much to correct that. So is your locale something other than "C" or "POSIX"? "en_US.ISO-8859-1" for example? Yup, thats what its set to. Perhaps ext/xml/tests/007.phpt could check whether it is able to successfully use strtoupper() on $xmldata - and if not, just skip that test? I have no problem with this test failing. It actually provides useful information. I'm not one to second-guess the intentions of the author of this test ('sniper' I think).But the reason for failure is not very clear, plus the manual (http://www.php.net/manual/en/ref.xml.php#xml.case-folding) makes no mention of the fact that it may fail and/or why. Using non-ascii chars for tags, doesn't fall into the 'best practice' category for me, but opinions differ :) We could make strtoupper locale aware, with an optional argument "charset", but even then it can fail (tried it). What would be nice - in general - is a "skip reason". Have that implemented already, but due to "zlib.c:313: undefined reference to `_php_stream_gets'" I'm now unable to test it properly. Running a cvsclean/update and stuff on a not so fast machine :( Met vriendelijke groeten / With kind regards, Webmaster IDG.nl Melvyn Sopacua