Re: Re: cvs: php4 /ext/mbstring/tests 027.inc027.phpt

> The only advantage putting everything in phpt is > is we can take a look at whole thing in one file. > Don't we have multiple windows or buffers? It's too > little advantage compare to have 2 files. First I looked at your style, I think it was somewhat cool, because then I wasn't able to run a single test with a cgi binary (before CLI era) > IMO, including script file give us more freedom to > write/execute test script. It's not efficient creating > normal script file when there is problem in phpt. > > Anyway, if you volunteer to change it, go ahead. > (Please don't for pgsql tests :) I'm never for the unreasonable standarlization. We've been working on a voluntary basis, and each style should be respected, unless it only causes increasing entropy aka inefficiency. I mean in some cases consistency is no longer the first thing, and then yours doesn't look like such a obstacle for me. > Please rename 001.phpt to something meaningful. > I just followed existing test script naming convention > and I don't like it, too. ;) Is good thing, though. Moriyoshi