Re: [PATCH] imagesavealpha()

On Thu, 20 Feb 2003, Jukka Holappa wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Hi, > > I have reported at http://bugs.php.net/?id=22323 that it's > impossible to > actually create png images that are partially transparent. I needed that > feature yesterday so I have created a patch (attached - mailer mangles > patches) for this. > > This patch introduces another function imagesavealpha($im,$bool) that > can be used to enable or disable (default) saving alpha information in > imagepng() etc. functions. > > Without this function, there is currently no way to do that. Patch looks ok to my untrained eye, though you should probably use zend_parse_parameters instead of zend_get_parameters (see other extensions for examples). > > I'm not 100% sure, if this function is defined in correct ifdefs > regarding bundled vs. not, but I guess this should be about right. > > There's no special testcase, it Works For Me (tm) and is 99% copied from > imagealphablending(). It really shouldn't contain any bugs :) > > When included, this patch closes bug #22323. Of course it needs > documentation too, but I'm not the right person to write that with my > lousy English. > > - - Jukka > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.2.1 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQE+VTfrYYWM2XTSwX0RAt+3AJoDu5jDoeM3qfVG6FhzPaDtlH6cNwCfYmwz > FvpjoNP+Qu/7s6N3bc1Iz/U= > =9mR9 > -----END PGP SIGNATURE----- > -- Tal Peer tal@php.net