RE: [PHP-DEV] [PATCH] imagesavealpha()
| From: | Steven Brown | Date: | Fri, 21 Feb 2003 06:51:29 +0000 |
| Subject: | RE: [PHP-DEV] [PATCH] imagesavealpha() | ||
| References: | 1 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-94418@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Jukka Holappa [mailto:jukkaho@mail.student.oulu.fi]
> Sent: Thursday, February 20, 2003 10:06 PM
> To: Steven Brown
> Cc: 'Pierre-Alain Joye'; rasmus@php.net; php-dev@lists.php.net
> Subject: Re: [PHP-DEV] [PATCH] imagesavealpha()
>
>
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Steven Brown wrote:
> > I sent in a patch on 1/2/2003 to fix various issues blocking use of
> > transparent truecolor PNGs in PHP and its bundled libgd
> that included
> > adding imagesavealpha() to PHP, did my patch fall out of the loop?
> > I've attached the original message about this and here's
> the link to
> > the
> > patch:
> >
> > http://www-cs.ucsd.edu/~sbrown/php-4.3.0-gd-swb.patch
>
> In my opinion your patch should be included instead.
>
> Your imagesavealpha() works identical to mine and even
> includes error handling for older gdlibs. At least that part
> is no way inferior.
>
> Other fixes are of course needed. There are problems handling
> some transparent images, but I didn't even try to fix them
> since I could work with truecolor images only.
Yeah, gd's a bug factory. :) After that patch though, it should be good
to go for palletized and truecolor PNGs that use boolean transparency.