extra realpath() found

From: Date: Thu, 01 Jan 1970 00:00:00 +0000
Subject: extra realpath() found
Groups: php.dev 
Request: Send a blank email to php-dev+get-94510@lists.php.net to get a copy of this message
Hey Sander, you fixed a problem back in July where you introduced a second realpath() call into the main execute_script() function. I understand what you were trying to achieve, but realpath() is way way too expensive to toss around like that, especially since we already do the realpath on the fopen of the script file. The bug in question was http://bugs.php.net/17720 and your fix was http://cvs.php.net/diff.php/php4/main/main.c?login=2&r1=1.461&r2=1.462&ty=u php_fopen_primary_script() calls expand_filepath() which does the realpath before we get to execute_script. Why not add the path to the included_files list at that point instead? Let me know if you feel like playing with it, otherwise I will. -Rasmus

« previous php.dev (#94510) next »