Re: extra realpath() found
| From: | Wez Furlong | Date: | Mon, 24 Feb 2003 17:15:17 +0000 |
| Subject: | Re: extra realpath() found | ||
| References: | 1 2 | Groups: | php.dev |
| Request: | Send a blank email to php-dev+get-94535@lists.php.net to get a copy of this message | ||
With my ze-stream patch to PHP 5 (in HEAD now), this can be avoided as
all files opened on the behalf of the engine can be managed via a single
function, provided that they set the zend file handle to open via a
filename.
--Wez.
On Mon, 24 Feb 2003, Sander Roobol wrote:
> On Sun, Feb 23, 2003 at 01:25:34PM -0800, Rasmus Lerdorf wrote:
> > Hey Sander, you fixed a problem back in July where you introduced a second
> > realpath() call into the main execute_script() function.
> > [...]
> > php_fopen_primary_script() calls expand_filepath() which does the realpath
> > before we get to execute_script. Why not add the path to the
> > included_files list at that point instead?
> >
> > Let me know if you feel like playing with it, otherwise I will.
>
> I looked into it briefly, as I don't have much time currently, but I
> discovered it's not that easy. php_fopen_primary_script() is only used
> by the CGI and Servlet SAPI, while all SAPIs call php_execute_script().
> We need to find a different place to update the included_files list, or
> make sure the SAPIs don't call realpath() themselves.
>
> I think it's better if someone with some more experience with PHP's
> internals looks into this, because it will take me too much time right
> now.
>
> Sander
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
>