Bug #66408 [Opn]: Wrong style file in chm documentation

From: Date: Tue, 25 Mar 2014 23:15:58 +0000
Subject: Bug #66408 [Opn]: Wrong style file in chm documentation
References: 1  Groups: php.doc.bugs 
Request: Send a blank email to doc-bugs+get-11092@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=66408&edit=1

 ID:                 66408
 Updated by:         bjori@php.net
 Reported by:        kulakov74 at yandex dot ru
 Summary:            Wrong style file in chm documentation
 Status:             Open
 Type:               Bug
 Package:            Doc Build problem
 Operating System:   Windows
 PHP Version:        Irrelevant
 Block user comment: N
 Private report:     N

 New Comment:

Interesting fix andy.

This config only provides defaults for any project using PhD (Facebook, PEAR, ...), so it can be
overwritten however people want.

Are you sure that fix is enough? We have the domain and everything else hardcoded?


Previous Comments:
------------------------------------------------------------------------
[2014-03-25 18:44:21] andy at andyburton dot co dot uk

I've had fun working out how this process works :)

The most simple fix is to just add the new themes to the config in https://github.com/php/phd/blob/master/phpdotnet/phd/Config.php

'css' => array ('theme-base.css', 'theme-medium.css')

This then loads both and compiles them into a single style.css file which is used in the CHM.

Is this config used for other builds, and so safe to change?

Andy

------------------------------------------------------------------------
[2014-03-14 18:20:39] bjori@php.net

There seems to be some misunderstanding here.. The CHM manual is not built manually.
It is an automatic process, done weekly.


It will be broken until this bug is fixed and a new release of PhD deployed on the building machine.


If you would like to contribute the fix, have a look at:
- https://github.com/php/phd/blob/master/phpdotnet/phd/Package/PHP/CHM.php#L466
- https://github.com/php/phd/blob/master/phpdotnet/phd/Package/PHP/Epub.php#L317

Should be trivial fix.
The question is, who will submit the github Pull Request first? :)

------------------------------------------------------------------------
[2014-03-14 12:50:27] olegin2310 at mail dot ru

Version of manual from March 14, 2014
style.css file is still wrong.

------------------------------------------------------------------------
[2014-03-13 09:44:48] andy at andy-burton dot co dot uk

Also having this problem having downloaded the latest chm today from php.net, running windows 8.1

------------------------------------------------------------------------
[2014-03-11 01:41:22] em dot dev at outlook dot com

I see on the 7th a new chm was compiled, but whoever did it completely disregarded my previous post.

Nicely done lads, nicely done!

THE STYLE.CSS IS CORRUPTED!!!

------------------------------------------------------------------------


The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at

    https://bugs.php.net/bug.php?id=66408


-- 
Edit this bug report at https://bugs.php.net/bug.php?id=66408&edit=1


Thread (18 messages)

« previous php.doc.bugs (#11092) next »