Edit report at https://bugs.php.net/bug.php?id=66408&edit=1
ID: 66408
Updated by: bjori@php.net
Reported by: kulakov74 at yandex dot ru
Summary: Wrong style file in chm documentation
-Status: Open
+Status: Closed
Type: Bug
Package: Doc Build problem
Operating System: Windows
PHP Version: Irrelevant
-Assigned To:
+Assigned To: bjori
Block user comment: N
Private report: N
New Comment:
The fix for this bug has been committed. Since the websites are not directly
updated from the repository, the fix might need some time to spread
across the globe to all mirror sites, including PHP.net itself.
Thank you for the report, and for helping us make PHP.net better.
I don't know what facebook plans are, they just forked the repo.
They currently don't provide chms so dunno.
I didn't realize the paths to the css file were so hardcoded anyway, so it would be fairly
broken for anyone trying to customize it anyway.
The fix looks good, and has been merged! https://github.com/php/phd/commit/881f6f382056a4246f2be9627b00a84599fb862b
Thank you !
Previous Comments:
------------------------------------------------------------------------
[2014-03-26 12:32:34] andy at andyburton dot co dot uk
Indeed - i have made some class changes to better fix the problem for both epub and chm which seem
to have worked well.
I've also extended it to take the google embedded fonts as it does on the php docs site and
store them locally, as it does with images.
I like the config solution as it says "use these php defaults, unless you specify
otherwise". It seems unnecessary to hard-code multiple stylesheet paths into the classes as
they were previously, and to provide anything other than an absolute fall-back (which i've kept
with theme-base.css).
Is the same phd repo being used by PEAR, FB etc? If so then i presume they will not want the php.net
css files in the config?
------------------------------------------------------------------------
[2014-03-25 23:15:57] bjori@php.net
Interesting fix andy.
This config only provides defaults for any project using PhD (Facebook, PEAR, ...), so it can be
overwritten however people want.
Are you sure that fix is enough? We have the domain and everything else hardcoded?
------------------------------------------------------------------------
[2014-03-25 18:44:21] andy at andyburton dot co dot uk
I've had fun working out how this process works :)
The most simple fix is to just add the new themes to the config in https://github.com/php/phd/blob/master/phpdotnet/phd/Config.php
'css' => array ('theme-base.css', 'theme-medium.css')
This then loads both and compiles them into a single style.css file which is used in the CHM.
Is this config used for other builds, and so safe to change?
Andy
------------------------------------------------------------------------
[2014-03-14 18:20:39] bjori@php.net
There seems to be some misunderstanding here.. The CHM manual is not built manually.
It is an automatic process, done weekly.
It will be broken until this bug is fixed and a new release of PhD deployed on the building machine.
If you would like to contribute the fix, have a look at:
- https://github.com/php/phd/blob/master/phpdotnet/phd/Package/PHP/CHM.php#L466
- https://github.com/php/phd/blob/master/phpdotnet/phd/Package/PHP/Epub.php#L317
Should be trivial fix.
The question is, who will submit the github Pull Request first? :)
------------------------------------------------------------------------
[2014-03-14 12:50:27] olegin2310 at mail dot ru
Version of manual from March 14, 2014
style.css file is still wrong.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
https://bugs.php.net/bug.php?id=66408
--
Edit this bug report at https://bugs.php.net/bug.php?id=66408&edit=1