Doc #52835 [Asn->Wfx]: readfile sample allows directory download

Edit report at http://bugs.php.net/bug.php?id=52835&edit=1 ID: 52835 Updated by: aharvey@php.net Reported by: kittya at breyfamily dot net Summary: readfile sample allows directory download -Status: Assigned +Status: Wont fix Type: Documentation Problem Package: Documentation problem PHP Version: 5.3.3 Assigned To: aharvey Block user comment: N New Comment: Actually, on second thoughts, I'm going to leave this as it is. It's an obviously contrived example and is_file() isn't necessarily sufficient anyway, since it doesn't cover links and special files. Closing won't fix. Previous Comments: ------------------------------------------------------------------------ [2010-09-14 10:29:13] kittya at breyfamily dot net Description: ------------ For the readfile function, sample 1, "Forcing a download using readfile()" uses file_exists to check whether $file is valid. However, if there is a directory by the name of $file, the sample code causes PHP to try to download the directory, which will likely be meaningless to the client. Expected result: ---------------- The sample should use is_file. Actual result: -------------- The sample currently uses file_exists. ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/bug.php?id=52835&edit=1