Bug #54208 [Fbk->Csd]: PhD_PEAR: no attributes for table-related tags

From: Date: Fri, 06 Apr 2012 14:55:33 +0000
Subject: Bug #54208 [Fbk->Csd]: PhD_PEAR: no attributes for table-related tags
References: 1  Groups: php.doc.bugs 
Request: Send a blank email to doc-bugs+get-8184@lists.php.net to get a copy of this message
Edit report at https://bugs.php.net/bug.php?id=54208&edit=1

 ID:                 54208
 User updated by:    avb@php.net
 Reported by:        avb@php.net
 Summary:            PhD_PEAR: no attributes for table-related tags
-Status:             Feedback
+Status:             Closed
 Type:               Bug
 Package:            Doc Build problem
 Operating System:   Irrelevant
 PHP Version:        Irrelevant
 Block user comment: N
 Private report:     N

 New Comment:

Yes. Sorry, forgot to close this.


Previous Comments:
------------------------------------------------------------------------
[2012-04-06 14:53:11] bjori@php.net

Is this then fixed?

------------------------------------------------------------------------
[2012-02-04 18:42:38] avb@php.net

Automatic comment from SVN on behalf of avb
Revision: http://svn.php.net/viewvc/?view=revision&revision=323057
Log: Make Phd_PEAR closer to generating valid HTML5. This also removes a few unnecessary overriden
methods in Package_PEAR_XHTML that caused e.g. missing attributes for table-related tags (see bug
#54208)

------------------------------------------------------------------------
[2011-03-09 19:07:45] avb@php.net

Description:
------------
For some strange reason phpdotnet\phd\Package_PEAR_XHTML overrides methods for formatting table tags
defined in phpdotnet\phd\Package_Generic_XHTML, for example:

    public function format_entry($open, $name, $attrs, $props)
    {
        if ($open) {
            if ($props['empty']) {
                return '<td></td>';
            }
            return '<td>';
        }
        return '</td>';
    }

Unlike code in parent class, this does not add any attributes whatsoever, so it is impossible to
even do colspan and rowspan in PEAR manual.

Commenting out format_table(), format_entry() and format_th_entry() improves output a lot.

Test script:
---------------
<entry morerows="1">...</entry>

Expected result:
----------------
<td rowspan="2">...</td>

Actual result:
--------------
<td>...</td>


------------------------------------------------------------------------



-- 
Edit this bug report at https://bugs.php.net/bug.php?id=54208&edit=1


Thread (3 messages)

« previous php.doc.bugs (#8184) next »