Re: svn: /phpdoc/en/trunk/reference/datetime/datetimeimmutable/ construct.xml
| From: | Peter Cowburn | Date: | Fri, 14 Aug 2015 15:18:37 +0000 |
| Subject: | Re: svn: /phpdoc/en/trunk/reference/datetime/datetimeimmutable/ construct.xml | ||
| References: | 1 | Groups: | php.doc.cvs |
| Request: | Send a blank email to doc-cvs+get-13573@lists.php.net to get a copy of this message | ||
On 14 August 2015 at 13:49, Christoph Michael Becker <cmb@php.net> wrote:
> cmb Fri, 14 Aug 2015 12:49:32 +0000
>
> Revision:
> http://svn.php.net/viewvc?view=revision&revision=337451
>
> Log:
> fixed wrong parameter name (Reflection!) (fixes #70265)
>
I'd *much* rather see this changed in php-src so that reflection gives a
more useful name. Changing the parameter name from "timezone" to "object"
is a step backwards.
>
> Bug: https://bugs.php.net/70265 (Verified) Wrong name of
> DateTimeImmutable::__construct's 2nd param
>
> Changed paths:
> U phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
>
> Modified:
> phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
> ===================================================================
> --- phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
> 2015-08-14 11:39:59 UTC (rev 337450)
> +++ phpdoc/en/trunk/reference/datetime/datetimeimmutable/construct.xml
> 2015-08-14 12:49:32 UTC (rev 337451)
> @@ -14,13 +14,13 @@
> <constructorsynopsis role="oop">
> <modifier>public</modifier>
> <methodname>DateTimeImmutable::__construct</methodname>
> <methodparam
>
> choice="opt"><type>string</type><parameter>time</parameter><initializer>"now"</initializer></methodparam>
> - <methodparam
>
> choice="opt"><type>DateTimeZone</type><parameter>timezone</parameter><initializer>&null;</initializer></methodparam>
> + <methodparam
>
> choice="opt"><type>DateTimeZone</type><parameter>object</parameter><initializer>&null;</initializer></methodparam>
> </constructorsynopsis>
> <para>&style.procedural;</para>
> <methodsynopsis role="procedural">
>
>
> <type>DateTimeImmutable</type><methodname>date_create_immutable</methodname>
> <methodparam
>
> choice="opt"><type>string</type><parameter>time</parameter><initializer>"now"</initializer></methodparam>
> - <methodparam
>
> choice="opt"><type>DateTimeZone</type><parameter>timezone</parameter><initializer>&null;</initializer></methodparam>
> + <methodparam
>
> choice="opt"><type>DateTimeZone</type><parameter>object</parameter><initializer>&null;</initializer></methodparam>
> </methodsynopsis>
> <para>
> Like <methodname>DateTime::__construct</methodname> but works with
>
>
> --
> PHP Documentation Commits Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>