Re: svn: /phpdoc/en/trunk/reference/datetime/datetimeimmutable/ construct.xml
| From: | Adam Harvey | Date: | Fri, 14 Aug 2015 18:57:05 +0000 |
| Subject: | Re: svn: /phpdoc/en/trunk/reference/datetime/datetimeimmutable/ construct.xml | ||
| References: | 1 2 | Groups: | php.doc.cvs |
| Request: | Send a blank email to doc-cvs+get-13576@lists.php.net to get a copy of this message | ||
On 14 August 2015 at 08:18, Peter Cowburn <petercowburn@gmail.com> wrote:
> On 14 August 2015 at 13:49, Christoph Michael Becker <cmb@php.net> wrote:
>
>> cmb Fri, 14 Aug 2015 12:49:32 +0000
>>
>> Revision:
>> http://svn.php.net/viewvc?view=revision&revision=337451
>>
>> Log:
>> fixed wrong parameter name (Reflection!) (fixes #70265)
>>
>
> I'd *much* rather see this changed in php-src so that reflection gives a
> more useful name. Changing the parameter name from "timezone" to "object"
> is a step backwards.
Agreed.
Also, I don't believe we're under any obligation to match parameter
names returned by reflection. It's obviously better if that's the
case, but we have other functions where the documentation has better
parameter names than php-src does, and I don't think anyone's
complained before this bug.
Of course, if we ever get keyword arguments... :)
Adam