Re: svn: /phpdoc/en/trunk/reference/filesystem/functions/ file-get-contents.xml

From: Date: Tue, 27 Apr 2010 14:03:15 +0000
Subject: Re: svn: /phpdoc/en/trunk/reference/filesystem/functions/ file-get-contents.xml
References: 1 2 3  Groups: php.doc.cvs 
Request: Send a blank email to doc-cvs+get-6493@lists.php.net to get a copy of this message
On 27 April 2010 14:58, Richard Quadling <rquadling@googlemail.com> wrote: > On 27 April 2010 14:42, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: >> On Tue, Apr 27, 2010 at 15:32, Peter Cowburn <salathe@php.net> wrote: >>> salathe                                  Tue, 27 Apr 2010 13:32:52 >>> +0000 >>> >>> Revision: >>> http://svn.php.net/viewvc?view=revision&revision=298661 >>> >>> Log: >>> use_include_path is boolean not integer >>> >>> Changed paths: >>>    U   phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml >>> >>> Modified: phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml >>> =================================================================== >>> --- phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml       >>>  2010-04-27 13:31:55 UTC (rev 298660) >>> +++ phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml       >>>  2010-04-27 13:32:52 UTC (rev 298661) >>> @@ -11,7 +11,7 @@ >>>   <methodsynopsis> >>>   >>>  <type>string</type><methodname>file_get_contents</methodname> >>>   >>>  <methodparam><type>string</type><parameter>filename</parameter></methodparam> >>> -   <methodparam >>> choice="opt"><type>int</type><parameter>use_include_path</parameter><initializer>0</initializer></methodparam> >>> +   <methodparam >>> choice="opt"><type>bool</type><parameter>use_include_path</parameter><initializer>0</initializer></methodparam> >> >> When was that argument renamed again? >> Its called flags in 5.3 atleast.. >> >> -Hannes >> >> -- >> PHP Documentation Commits Mailing List (http://www.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > http://svn.php.net/viewvc/php/php-src/trunk/ext/standard/file.c?view=annotate#l520å|�sfm6„ñžÈ > ë*s > } > "ᴸnK’Â\”ùhttp://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/standard/file.c?view=annotate#l521 > > Both show the param as bool use_include_path and retrieve it as a 'b' This is why I changed the type in this commit. With these changes, the description to use FILE_USE_INCLUDE_PATH conflicts somewhat if we are asking people to use a boolean. Any suggestions for the description; the constant will still work since its value is 1 but should we ignore that fact? What about people who might already be using FILE_USE_INCLUDE_PATH? > > > -- > ----- > Richard Quadling > "Standing on the shoulders of some very clever giants!" > EE : http://www.experts-exchange.com/M_248814.html > EE4Free : http://www.experts-exchange.com/becomeAnExpert.jsp > Zend Certified Engineer : > http://zend.com/zce.php?c=ZEND002498&r=213474731 > ZOPA : http://uk.zopa.com/member/RQuadling > > -- > PHP Documentation Commits Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >

« previous php.doc.cvs (#6493) next »