Re: svn: /phpdoc/en/trunk/reference/filesystem/functions/ file-get-contents.xml

From: Date: Tue, 27 Apr 2010 15:05:39 +0000
Subject: Re: svn: /phpdoc/en/trunk/reference/filesystem/functions/ file-get-contents.xml
References: 1 2 3 4  Groups: php.doc.cvs 
Request: Send a blank email to doc-cvs+get-6494@lists.php.net to get a copy of this message
On Tue, Apr 27, 2010 at 16:03, Peter Cowburn <salathe@php.net> wrote: > On 27 April 2010 14:58, Richard Quadling <rquadling@googlemail.com> wrote: >> On 27 April 2010 14:42, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: >>> On Tue, Apr 27, 2010 at 15:32, Peter Cowburn <salathe@php.net> wrote: >>>> salathe                                  Tue, 27 Apr 2010 13:32:52 >>>> +0000 >>>> >>>> Revision: >>>> http://svn.php.net/viewvc?view=revision&revision=298661 >>>> >>>> Log: >>>> use_include_path is boolean not integer >>>> >>>> Changed paths: >>>>    U   phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml >>>> >>>> Modified: phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml >>>> =================================================================== >>>> --- phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml       >>>>  2010-04-27 13:31:55 UTC (rev 298660) >>>> +++ phpdoc/en/trunk/reference/filesystem/functions/file-get-contents.xml       >>>>  2010-04-27 13:32:52 UTC (rev 298661) >>>> @@ -11,7 +11,7 @@ >>>>   <methodsynopsis> >>>>   >>>>  <type>string</type><methodname>file_get_contents</methodname> >>>>   >>>>  <methodparam><type>string</type><parameter>filename</parameter></methodparam> >>>> -   <methodparam >>>> choice="opt"><type>int</type><parameter>use_include_path</parameter><initializer>0</initializer></methodparam> >>>> +   <methodparam >>>> choice="opt"><type>bool</type><parameter>use_include_path</parameter><initializer>0</initializer></methodparam> >>> >>> When was that argument renamed again? >>> Its called flags in 5.3 atleast.. >>> >> >> >> http://svn.php.net/viewvc/php/php-src/trunk/ext/standard/file.c?view=annotate#l520 >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/standard/file..c?view=annotate#l521 What the proto or zpp() uses is irrelevant. bjori@jessica:~$ php --rf file_get_contents Function [ <internal:standard> function file_get_contents ] { - Parameters [5] { Parameter #0 [ <required> $filename ] Parameter #1 [ <optional> $flags ] Parameter #2 [ <optional> $context ] Parameter #3 [ <optional> $offset ] Parameter #4 [ <optional> $maxlen ] } } >> Both show the param as bool use_include_path and retrieve it as a 'b' > > This is why I changed the type in this commit. With these changes, the > description to use FILE_USE_INCLUDE_PATH conflicts somewhat if we are > asking people to use a boolean.  Any suggestions for the description; > the constant will still work since its value is 1 but should we ignore > that fact? What about people who might already be using > FILE_USE_INCLUDE_PATH? I think we should pretend that the parameter is int, called flags, and mention that FILE_USE_INCLUDE_PATH is defined as 1 so passing boolean is fine. -Hannes

« previous php.doc.cvs (#6494) next »