Re: [Spam 05.70] RE: [PHP-DOC] [PATCH] rtl...

> Thanks; looks good, although I'd prefer it if we didn't have too many > special cases going on. > You have an RTL constant to indicate that the content is RTL, but then there > are a number of places where you use that to generate a dir="rtl" attribute. > It would be better to define a DIRECTION constant that held dir="rtl" or > dir="ltr" as appropriate for the language, and use that unconditionally. i'll adopt the idea. > Likewise for the copyright text in style_mapping.php; just fold it into a > single line that includes the directionality in any case: > return sprintf('<p><DEFANGED_div dir="ltr" > class="copyright">Copyright &copy; %s by > <DEFANGED_span %s>%s</ DEFANGED_span></p><DEFANGED_div>', > implode(", ", $y), DIRECTION, $holder); this line is anyway candidate to change due to the "by" that have to be translated by into entity that reflect the translation (my preference btw, is is one dictionary file per language to keep the livedocs core independent). this change 'll change this lumpy line logic - lets just i keep it simple for now. i touched this line just because i wanted that the manual cover looks professional. > The other thing I noticed was that you have: > $map['emphasis'] = 'format_emphasis'; > but then: > function format_em($node) { ... } i'll fix it. it was lost on last model changing. --Wez.