Re: [Spam 05.70] RE: [PHP-DOC] [PATCH] rtl...

"Moshe Doron" <mosdoron@netvision.net.il> wrote in message news:20040505181508.49785.qmail@pb1.pair.com... > > Thanks; looks good, although I'd prefer it if we didn't have too many > > special cases going on. > > > You have an RTL constant to indicate that the content is RTL, but then > there > > are a number of places where you use that to generate a dir="rtl" > attribute. > > It would be better to define a DIRECTION constant that held dir="rtl" or > > dir="ltr" as appropriate for the language, and use that unconditionally. > > i'll adopt the idea. > i didn't read you carfuly enough. on rtl mode we need times to dump dir=rtl and times dir=ltr on non-rtl languages we have no worries about this issue. my guideline is to leave the ltr document as it was before my plays. you never know how any browser behave after dir=ltr even if the it sensible that this instruction should have no effect. anyway i follow your line of thought and make the RTL hold the text. here the new patch: http://moshe.i-com-it.com/patchs/livedocs-rtl4.patch.txt --/moshe.